fix: Python 3.10 exports and unfiltered wasm bundle extraction - #105
Merged
jourdain merged 2 commits intoSep 27, 2026
Merged
Conversation
ZipFile.mkdir was added in Python 3.11, so to_wazex and to_html raised AttributeError on Python 3.10, which requires-python still allows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Calling tarfile.extractall without a filter emits a DeprecationWarning on Python 3.12 and 3.13 and trusts member paths on older versions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
user27182
marked this pull request as ready for review
September 26, 2026 17:54
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two problems in 1.7.0 that CI does not see because it only tests Python 3.13.
to_wazexandto_htmlraiseAttributeError: 'ZipFile' object has no attribute 'mkdir'on Python 3.10, whichrequires-python = ">=3.10"allows.ZipFile.mkdirwas added in 3.11; thestates/andblobs/directory entries are now written withwritestr, so the archive layout is unchanged.setup_wasm_directorycallstarfile.extractallwithout a filter, which emits aDeprecationWarningon Python 3.12 and 3.13 and trusts member paths before 3.14. It now usesfilter="data"when available; the VTK 9.7.0 bundle extracts identically with it.Found through trame-pyvista, whose test suite turns warnings into errors: there the warning aborted extraction, so every export downloaded the bundle again.
Changes drafted by Claude Opus 5.5 but fully understood by me.
🤖 Generated with Claude Code (Claude Opus 5.5)